Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loggly): fix the error caused by the missing /bin/hostname #13788

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix(loggly): fix the error caused by the missing /bin/hostname #13788

merged 3 commits into from
Oct 29, 2024

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon commented Oct 25, 2024 •
edited
Loading

Summary

  1. Refactor the PDK's get_hostname to use only the gethostname system call to retrieve the hostname.
  2. Loggly uses the PDK's get_hostname to retrieve the hostname.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-6046

@github-actions github-actions bot added core/pdk plugins/loggly cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 25, 2024
@Water-Melon Water-Melon force-pushed the fti6046 branch 2 times, most recently from d63cce5 to fe50864 Compare October 25, 2024 03:52
@Water-Melon Water-Melon marked this pull request as ready for review October 25, 2024 06:20
ms2008
ms2008 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ms2008 ms2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended that if the first call succeeds, we can cache the hostname in PDK so that there is no need to generate a system call for the next calls.

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 25, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 25, 2024
@Water-Melon Water-Melon requested a review from ms2008 October 25, 2024 09:13
@Water-Melon
fix(loggly): fix the error caused by the missing /bin/hostname
16aa4b6 
1. Refactor the PDK's get_hostname to use only the gethostname system call to retrieve the hostname.
2. Loggly uses the PDK's get_hostname to retrieve the hostname.

FTI-6046
@windmgc windmgc merged commit 0bcd6c5 into master Oct 29, 2024
26 checks passed
@windmgc windmgc deleted the fti6046 branch October 29, 2024 03:01
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

StarlightIbuki pushed a commit that referenced this pull request Oct 31, 2024
@Water-Melon @StarlightIbuki
fix(loggly): fix the error caused by the missing /bin/hostname (#13788)
af94c8f 
* fix(loggly): fix the error caused by the missing /bin/hostname

1. Refactor the PDK's get_hostname to use only the gethostname system call to retrieve the hostname.
2. Loggly uses the PDK's get_hostname to retrieve the hostname.

FTI-6046
lhanjian pushed a commit that referenced this pull request Dec 23, 2024
@Water-Melon @windmgc
fix(loggly): fix the error caused by the missing /bin/hostname (#13788)
227e0b2 
* fix(loggly): fix the error caused by the missing /bin/hostname

1. Refactor the PDK's get_hostname to use only the gethostname system call to retrieve the hostname.
2. Loggly uses the PDK's get_hostname to retrieve the hostname.

FTI-6046

(cherry picked from commit 0bcd6c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

@ms2008 ms2008 ms2008 approved these changes

Assignees

@Water-Melon Water-Melon

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk plugins/loggly size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Water-Melon @team-gateway-bot @ms2008 @oowl @windmgc