fix(incremental): dont delete old entity from LMDB if we clear it already #13757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
|
Please refer to this commit: 3e25a80 |
wait a minite |
team-gateway-bot
added
the
author/community
|
already fixed in original pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix this case failure: FAIL spec/02-integration/09-hybrid_mode/01-sync_spec.lua:146: CP/DP communication #postgres inc_sync=on sync works proxy on DP follows CP config.
DP receive full sync deltas, but one of this operation needs it to delete a key from the lmdb, but this key does not exist in lmdb if the detals has wipe flag, so it trigger error:
2024/10/15 14:53:05 [error] 31827#0: *8 [lua] rpc.lua:329: unable to create worker mutex and sync: MDB_NOTFOUND: No matching key/data pair foundChecklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5551