Fix(tests): enable incremental sync for hybrid case #13746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chobits
force-pushed
the
fix/incremental-case-hybrid
branch
2 times, most recently
from
fb66cea to
8a9e0f2
Compare
chobits
force-pushed
the
fix/incremental-case-hybrid
branch
2 times, most recently
from
88035b3 to
433e7b6
Compare
chronolaw
reviewed
Oct 15, 2024
chronolaw
reviewed
Oct 15, 2024
| @@ -73,7 +73,7 @@ end | |||
|
|
|||
|
|
|||
| -- XXX TODO: enable inc_sync = "on" | |||
There was a problem hiding this comment.
If we fixed this test, should we remove the TODO comment?
There was a problem hiding this comment.
ok, later i'll clear this pr
chobits
force-pushed
the
fix/incremental-case-hybrid
branch
from
45550cd to
4924f14
Compare
chronolaw
approved these changes
Oct 15, 2024
chronolaw
force-pushed
the
fix/incremental-case-hybrid
branch
2 times, most recently
from
5d14a93 to
3e25a80
Compare
chronolaw
approved these changes
Oct 16, 2024
chronolaw
force-pushed
the
fix/incremental-case-hybrid
branch
from
bbdea01 to
783fe91
Compare
team-gateway-bot
added
the
author/community
dndx
pushed a commit
that referenced
this pull request
Oct 16, 2024
* fix(tests): enable inc sync for 01-sync_spec.lua * fix(incremental): dont delete old entity from LMDB if we clear it already * dont modify crud type even though we dont delete old entity from lmdb * localize ns_delta.wipe * localize ns_delta.wipe - part 2 * fix that cp will not init clustering * refactor old_entity logic * cp should always support full sync protocol * Revert "cp should always support full sync protocol" This reverts commit 6803958. * Revert "fix that cp will not init clustering" This reverts commit b84f261. * Revert "fix(tests): enable inc sync for 01-sync_spec.lua" This reverts commit 54d0f54. --------- Co-authored-by: chronolaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5551