tests(helpers): fixed incorrect conf.database setting in get_db_utils #13738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
team-gateway-bot
added
the
author/community
chobits
changed the title
chronolaw
reviewed
Oct 10, 2024
spec/internal/db.lua
Outdated
| @@ -277,6 +277,8 @@ end | |||
| -- } | |||
| local function get_db_utils(strategy, tables, plugins, vaults, skip_migrations) | |||
| strategy = strategy or conf.database | |||
| conf.database = strategy | |||
There was a problem hiding this comment.
Could you add a comment for this change? It may be helpful for the future maintainers.
chronolaw
approved these changes
Oct 10, 2024
|
Close, since it has been merged into #13157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original function get_db_utils does not set the right value of
conf.database(kong.confiuration.database)from its first parameterstrategy.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]