Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(incremental sync): fix incorrect return value from Workspace:select_by_name #13733

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(incremental sync): fix incorrect return value from Workspace:select_by_name #13733

merged 1 commit into from
Oct 10, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Oct 8, 2024 •
edited
Loading

Summary

If we could not get default id from lmdb, it should return nil from select_by_name API rather than returning empty table {}

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chobits chobits marked this pull request as draft October 8, 2024 08:39
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Oct 8, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 9, 2024
@chobits chobits changed the title [Do not merge] add debug log to test case [Do NOT MERGE] add debug log to test case of incremental sync Oct 9, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 9, 2024
@chobits chobits force-pushed the fix/incr-test-cases-wasm branch from a83019c to 05fe53e Compare October 10, 2024 03:37
@chobits chobits changed the title [Do NOT MERGE] add debug log to test case of incremental sync fix(incremental sync): fix wrong return value from Workspace:select_by_name Oct 10, 2024
@chobits chobits requested a review from chronolaw October 10, 2024 03:39
@chobits chobits marked this pull request as ready for review October 10, 2024 03:39
@chobits chobits mentioned this pull request Oct 10, 2024
Merged
@chobits chobits changed the title fix(incremental sync): fix wrong return value from Workspace:select_by_name fix(incremental sync): fix incorrect return value from Workspace:select_by_name Oct 10, 2024
@chobits chobits force-pushed the fix/incr-test-cases-wasm branch from 05fe53e to b3ccb9b Compare October 10, 2024 03:40
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 10, 2024
@chronolaw chronolaw merged commit ecfdd07 into feat/incremental Oct 10, 2024
32 of 35 checks passed
@chronolaw chronolaw deleted the fix/incr-test-cases-wasm branch October 10, 2024 04:13
chronolaw pushed a commit that referenced this pull request Oct 12, 2024
@chobits @chronolaw
fix incorrect return value from Workspaces:select_by_name (#13733)
3cd4eca
dndx pushed a commit that referenced this pull request Oct 16, 2024
@chobits @dndx
fix incorrect return value from Workspaces:select_by_name (#13733)
8230d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

Assignees

@chobits chobits

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/proxy schema-change-noteworthy size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chobits @chronolaw @team-gateway-bot