fix(core): always pass ngx.ctx to log_init_worker_errors
#13731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
fix/pass-ctx-to-log-init-worker-errors
branch
from
467a6e4 to
7a77881
Compare
ADD-SP
reviewed
Oct 8, 2024
| @@ -0,0 +1,4 @@ | |||
| message: | | |||
| Fix to always pass `ngx.ctx` to `log_init_worker_errors` as otherwise it may runtime crash. | |||
There was a problem hiding this comment.
I think this msg is very technical, could you make it more customer-friendly?
There was a problem hiding this comment.
@ADD-SP there is no way to make it customer friendly. Thus I was thinking about removing the whole changelog. But then I though people start complaining that it is not there. It is internal change that I am not sure has anyone except me hit. If you are looking after something like "Made Kong more robust when logging errors when starting a node". Then customers start to ask "how it is now more robust, should I know more about this".
There was a problem hiding this comment.
IMO it's perfectly fine to leave internal changes off the changelog.
flrgh
approved these changes
Nov 1, 2024
gszr
approved these changes
Nov 12, 2024
|
Successfully created cherry-pick PR for |
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit fd7ea93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just saw this on my local machine when started to kill -9 worker processes on a control plane. So just a tiny fix here. Not sure how easy this is to test, but it is quite an obvious fix and bug. Without this the
log_init_worker_errorsmay runtime crash.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md