fix(admin-api): nested parameters can be parsed correctly when using form-urlencoded requests #13668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form-urlencoded requests
github-actions
bot
added
the
cherry-pick kong-ee
ms2008
changed the title
team-gateway-bot
added
the
author/community
|
Have you tried using curl to send requests for verification without using a testing framework? |
Yes, I did. The behavior is consistent with what I described above |
tzssangglass
approved these changes
Oct 30, 2024
windmgc
approved these changes
Oct 31, 2024
|
Successfully created cherry-pick PR for |
StarlightIbuki
pushed a commit
that referenced
this pull request
Oct 31, 2024
…form-urlencoded requests (#13668) When using curl to send a form-urlencoded request with nested parameters, such as $ curl -X POST http://localhost:8001/parsed_params \ --data 'items[1]=foo' \ --data 'items[2]=bar' the expected response is {"items":["foo","bar"]}, but instead, it returns {"items":{}}. This is actually an EE issue, but I see that there is a risk of this in CE even though it doesn't currently occur. So I initiated that fix on CE. The cause of the problem is due to the fact that nested parameters are lost when the decode_args method is called twice, without this fix. FTI-6165
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
…form-urlencoded requests (#13668) When using curl to send a form-urlencoded request with nested parameters, such as $ curl -X POST http://localhost:8001/parsed_params \ --data 'items[1]=foo' \ --data 'items[2]=bar' the expected response is {"items":["foo","bar"]}, but instead, it returns {"items":{}}. This is actually an EE issue, but I see that there is a risk of this in CE even though it doesn't currently occur. So I initiated that fix on CE. The cause of the problem is due to the fact that nested parameters are lost when the decode_args method is called twice, without this fix. FTI-6165 (cherry picked from commit 5cab556)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
curlto send a form-urlencoded request with nested parameters, such asthe expected response is
{"items":["foo","bar"]}, but instead, it returns{"items":{}}.This is actually an EE issue, but I see that there is a risk of this in CE even though it doesn't currently occur. So I initiated that fix on CE.
The cause of the problem is due to the fact that nested parameters are lost when the decode_args method is called twice, without this fix.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6165