Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): rename directory details to internal #13665

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5330

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 13, 2024
@chronolaw chronolaw marked this pull request as ready for review September 13, 2024 03:54
@ADD-SP ADD-SP merged commit 1c4b859 into master Sep 14, 2024
25 checks passed
@ADD-SP ADD-SP deleted the tests/rename_to_internal branch September 14, 2024 01:39
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13665-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13665-to-master-to-upstream
git checkout -b cherry-pick-13665-to-master-to-upstream
ancref=$(git merge-base 2c4a0b6b22359a1a329c6a56fae5a14f03424351 5686c74a6e9921f008c286440922e08685629210)
git cherry-pick -x $ancref..5686c74a6e9921f008c286440922e08685629210

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 14, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants