Fix: Fix broken link in contributing.md #13658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-eng-enablement
added
the
author/community
3 tasks
liverpool8056
approved these changes
Sep 12, 2024
outsinre
approved these changes
Sep 13, 2024
Although, should that point at https://github.com/Kong/kong/blob/master/changelog/changelog-template.yaml ? There does not appar to be anything in that readme for contributors to read.
outsinre
force-pushed
the
ad-changelog-readme
branch
from
57250ef to
d889510
Compare
|
@liverpool8056 @outsinre 👋 what is required to get this MR merged :) ? If it's waiting for some action from me - what is that action? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/Kong/kong/blob/master/CHANGELOG/README.md does not exist.
Fix the url. Although, should that point at changelog-template.yaml instead?
I don't see anything in that readme directly relevant to contributors (who are not going to be generating a changelog themselves). Alternatively, as a new contributor, I'm not sure how to read these instructions and would be happy to update them :).
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]