Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk.service): corrects the error message in pdk.service.set_retries #13655

Closed
wants to merge 1 commit into from

Conversation

liverpool8056
Copy link
Contributor

Summary

The message thrown from set_retries is an miswritten one in case that the argument is out of range.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-6222

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 12, 2024
@liverpool8056 liverpool8056 requested a review from oowl September 12, 2024 02:16
@liverpool8056 liverpool8056 force-pushed the fix-pdk-service-err-msg branch from 70ffdff to 16e7963 Compare September 12, 2024 02:17
@liverpool8056 liverpool8056 marked this pull request as draft September 12, 2024 02:40
@liverpool8056
Copy link
Contributor Author

A similar PR has been already created #13605, switch this to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant