-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdk): inspect should log at notice level #13642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/logs
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Sep 10, 2024
outsinre
approved these changes
Sep 10, 2024
LGTM though no tests. |
raoxiaoyan
approved these changes
Sep 10, 2024
nowNick
approved these changes
Sep 10, 2024
bungle
force-pushed
the
log/inspect
branch
2 times, most recently
from
September 10, 2024 12:42
1567e6f
to
5e58efe
Compare
….inspect Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
approved these changes
Sep 10, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13642-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13642-to-master-to-upstream
git checkout -b cherry-pick-13642-to-master-to-upstream
ancref=$(git merge-base 1989ea7091b3cb191a6eeea6928f2493d798cefb 116c20dd6be181ca2def6099d42e2ba63e645803)
git cherry-pick -x $ancref..116c20dd6be181ca2def6099d42e2ba63e645803 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 10, 2024
bungle
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 10, 2024
EE cherry can be found here: https://github.com/Kong/kong-ee/pull/10224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The inspect facility is used a lot for troubleshooting, but currently requires
debug
level logs to be enabled, which will cause a lot of noise. Also: the documentation still mentions inspect to log atnotice
level. So this fix aligns the code to the documentation.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference