Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk): inspect should log at notice level #13642

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(pdk): inspect should log at notice level #13642

merged 2 commits into from
Sep 10, 2024

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Sep 10, 2024

Summary

The inspect facility is used a lot for troubleshooting, but currently requires debug level logs to be enabled, which will cause a lot of noise. Also: the documentation still mentions inspect to log at notice level. So this fix aligns the code to the documentation.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

@github-actions github-actions bot added core/logs cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 10, 2024
Reverts #7815

The inpect facility is used a lot for troubleshooting, but curently
requires debug level logs to be enabled, which will cause a lot of
noise. Also: the documentation still mentions inspect to log at notice level.

FTI-6215
@Tieske Tieske marked this pull request as ready for review September 10, 2024 09:51
@outsinre
Copy link
Contributor

LGTM though no tests.

@bungle bungle force-pushed the log/inspect branch 2 times, most recently from 1567e6f to 5e58efe Compare September 10, 2024 12:42
@bungle bungle merged commit 4f63f13 into master Sep 10, 2024
26 checks passed
@bungle bungle deleted the log/inspect branch September 10, 2024 15:06
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13642-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13642-to-master-to-upstream
git checkout -b cherry-pick-13642-to-master-to-upstream
ancref=$(git merge-base 1989ea7091b3cb191a6eeea6928f2493d798cefb 116c20dd6be181ca2def6099d42e2ba63e645803)
git cherry-pick -x $ancref..116c20dd6be181ca2def6099d42e2ba63e645803

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 10, 2024
@bungle bungle removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 10, 2024
@bungle
Copy link
Member

bungle commented Sep 10, 2024

EE cherry can be found here: https://github.com/Kong/kong-ee/pull/10224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/logs size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants