-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(helpers): separate customized asserts #13628
Conversation
@@ -0,0 +1,823 @@ | |||
local cjson = require("cjson.safe") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the naming of spec/details
feels bit confusing. we might want to call something like spec/tools
or spec/internal
.
We also have spec/helpers
that some of them also registers the custom assert functions. please consider consolidate them.
not blocker for this specific PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will do it in the future, thanks. KAG-5330.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that details
is not a good name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rename this directory after these PRs are merged.
please validate that the documentation still renders properly when changing those helper files.
should render the docs properly. Users access this through |
See comment #13630 (comment) |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13628-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13628-to-master-to-upstream
git checkout -b cherry-pick-13628-to-master-to-upstream
ancref=$(git merge-base b861d1fc030c43923151241d7e4f6710ab2a3a5a b558c17f6aace568554f4ca613affb2b4ac40cee)
git cherry-pick -x $ancref..b558c17f6aace568554f4ca613affb2b4ac40cee |
Summary
KAG-5252
lookup()
to misc moduleChecklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]