fix(ai): llm model moved to share state to guarantee consistency #13627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
fffonion
approved these changes
Sep 6, 2024
oowl
approved these changes
Sep 6, 2024
tysoekong
force-pushed
the
fix/ai_model_name_consistency
branch
from
66a26f2 to
c541fe8
Compare
tysoekong
force-pushed
the
fix/ai_model_name_consistency
branch
from
895f678 to
54cd557
Compare
|
@fffonion Added integration test now for this, please verify once more |
tysoekong
force-pushed
the
fix/ai_model_name_consistency
branch
2 times, most recently
from
e3828ee to
d3559e5
Compare
|
@fffonion Should pass now |
tysoekong
force-pushed
the
fix/ai_model_name_consistency
branch
from
d3559e5 to
6d62fae
Compare
fffonion
reviewed
Sep 6, 2024
|
two lint errors, rerunning CI |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
) (cherry picked from commit ad3e19a)
Merged
3 tasks
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13627-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13627-to-master-to-upstream
git checkout -b cherry-pick-13627-to-master-to-upstream
ancref=$(git merge-base b861d1fc030c43923151241d7e4f6710ab2a3a5a 2aa3a4f39804e56cffb7c6ed414697a025135df0)
git cherry-pick -x $ancref..2aa3a4f39804e56cffb7c6ed414697a025135df0 |
|
Successfully created backport PR for |
github-actions
bot
added
the
incomplete-cherry-pick
locao
removed
the
incomplete-cherry-pick
guanlan
pushed a commit
that referenced
this pull request
Sep 9, 2024
) (#13633) (cherry picked from commit ad3e19a) Co-authored-by: Jack Tysoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets request model name consistently across AI plugins.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]