Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(helpers): separate dns_mock module #13617

Merged
merged 1 commit into from
Sep 6, 2024
Merged

tests(helpers): separate dns_mock module #13617

merged 1 commit into from
Sep 6, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 4, 2024 •
edited
Loading

Summary

KAG-5321

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 4, 2024
@chronolaw chronolaw marked this pull request as ready for review September 4, 2024 09:31
@chronolaw chronolaw marked this pull request as draft September 4, 2024 10:53
@chronolaw chronolaw marked this pull request as ready for review September 4, 2024 23:47
@chronolaw chronolaw force-pushed the tests/clean_helpers_dns_mock branch from 4e74a3e to cfba359 Compare September 5, 2024 02:55
@ADD-SP ADD-SP merged commit b861d1f into master Sep 6, 2024
25 checks passed
@ADD-SP ADD-SP deleted the tests/clean_helpers_dns_mock branch September 6, 2024 02:51
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @Water-Melon @ADD-SP