-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shorthand_fields): remove translate_backwards in favor of replaced_with #13604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/rate-limiting
plugins/acme
core/db
plugins/response-ratelimiting
schema-change-noteworthy
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Sep 2, 2024
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Sep 16, 2024
bungle
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to make this more readable, I think you get an idea from this and can work forward on it.
nowNick
force-pushed
the
refactor/remove-translate-backwards
branch
from
September 27, 2024 08:01
0127d92
to
5648799
Compare
…r of replaced_with PR Review
nowNick
force-pushed
the
refactor/remove-translate-backwards
branch
from
September 27, 2024 08:14
5648799
to
fe67a1e
Compare
bungle
approved these changes
Sep 30, 2024
bungle
approved these changes
Sep 30, 2024
oowl
approved these changes
Sep 30, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13604-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13604-to-master-to-upstream
git checkout -b cherry-pick-13604-to-master-to-upstream
ancref=$(git merge-base a6ccbb1af2169a9edbf4491a91ecaf5d2d7fb067 fe67a1ef4d903b4fddbbd72a93a7faa5853cdd73)
git cherry-pick -x $ancref..fe67a1ef4d903b4fddbbd72a93a7faa5853cdd73 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Oct 1, 2024
nowNick
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author/community
PRs from the open-source community (not Kong Inc)
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/db
plugins/acme
plugins/rate-limiting
plugins/response-ratelimiting
schema-change-noteworthy
size/M
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've introduced
replaced_with
when working onshorthand_fields
when used as deprecation and making sure that incoming request do not contain mismatched data: #13565This made
translate_backwards
field obsolete asreplaced_with
is just more robust and intuitive. This PR removes that code.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-5298