Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin)(correlationId) increase priority order for plugin to mat… #13581

Merged
merged 17 commits into from
Oct 15, 2024
+7 −2
Merged

feat(plugin)(correlationId) increase priority order for plugin to mat… #13581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e6f8a76
feat(plugin)(correlationId) increase priority order for plugin to mat…
andrewgkew Aug 27, 2024
4acf23f
feat(plugin)(correlationId) adding changelog for update
andrewgkew Aug 27, 2024
1a99f3f
Adjusting tests due to plugin order
andrewgkew Aug 27, 2024
9eb21a2
fix(core): make deprecated shorthand fields take precedence when new …
nowNick Aug 28, 2024
0663e33
fix(*): reject config if both deprecated and new field defined and th…
nowNick Aug 29, 2024
7a22ba0
feat(ci): pr diff
samugi Jul 19, 2024
25bc2c8
feat(deps): add ada - whatwg-compliant and fast url parser (#13120)
bungle Sep 3, 2024
98b8b4a
feat(tools): add `get_updated_now()` in time tools (#13575)
chronolaw Sep 4, 2024
044bb7f
fix(rate-limiting-plugin): fix a bug where the return values from `ge…
liverpool8056 Sep 4, 2024
75d6c84
tests(helpers): separate miscellaneous and shell functions (#13542)
chronolaw Sep 4, 2024
78b5ebc
style(tools): should not use `tools.utils` module (#13615)
chronolaw Sep 4, 2024
c9a7058
tests(helper): separate module reload function (#13616)
chronolaw Sep 5, 2024
ad03a0b
tests(helpers): separate grpc functions (#13552)
chronolaw Sep 5, 2024
89669d5
fix(vault): let vault entity cache key not containing workspace id (#…
windmgc Sep 5, 2024
e7042d3
fix(aws-lambda): add null handling for multiValueHeaders (#13533)
windmgc Sep 5, 2024
4723a6e
feat(runloop): added the workspace id into the plugin config in the p…
catbro666 Sep 5, 2024
c689670
Merge branch 'master' into feat/correlation-id-priority-order
andrewgkew Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/kong/feat-correlation-id-order.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
message: |
Increased the priority order of the correlation id to 100001 from 1 so that the plugin can be used
with other plugins especially custom auth plugins.
type: feature
scope: Core
2 changes: 1 addition & 1 deletion kong/plugins/correlation-id/handler.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ end
local CorrelationIdHandler = {}


CorrelationIdHandler.PRIORITY = 1
CorrelationIdHandler.PRIORITY = 100001
CorrelationIdHandler.VERSION = kong_meta.version


Expand Down
2 changes: 1 addition & 1 deletion spec/01-unit/12-plugins_order_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ describe("Plugins", function()

local order = {
"pre-function",
"correlation-id",
"zipkin",
"bot-detection",
"cors",
Expand Down Expand Up @@ -94,7 +95,6 @@ describe("Plugins", function()
"syslog",
"grpc-web",
"request-termination",
"correlation-id",
"post-function",
}

Expand Down
Loading