Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): add get_updated_now() in time tools #13575

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat(tools): add get_updated_now() in time tools #13575

merged 5 commits into from
Sep 4, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 27, 2024 •
edited
Loading

Summary

KAG-5280

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 27, 2024
@chronolaw chronolaw marked this pull request as ready for review August 27, 2024 02:34
@chronolaw chronolaw requested a review from Water-Melon August 27, 2024 03:44
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 27, 2024
bungle
bungle reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is also quite common: aka get_duration(start)

@ADD-SP ADD-SP merged commit 78bee02 into master Sep 4, 2024
26 checks passed
@ADD-SP ADD-SP deleted the feat/tools_update_now branch September 4, 2024 02:02
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

andrewgkew pushed a commit to andrewgkew/kong that referenced this pull request Sep 5, 2024
@chronolaw @andrewgkew
feat(tools): add get_updated_now() in time tools (Kong#13575)
98b8b4a 
https://konghq.atlassian.net/browse/KAG-5280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@bungle bungle bungle approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering core/db size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @bungle @Water-Melon @ADD-SP