Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): separate grpc test functions #13552

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 22, 2024

Summary

It is one of the serial refactors of helpers.lua

KAG-5242

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 22, 2024
@chronolaw chronolaw changed the title tests(helpers): separate grpc functions refactor(helpers): separate grpc test functions Aug 22, 2024
@chronolaw chronolaw changed the title refactor(helpers): separate grpc test functions tests(helpers): separate grpc test functions Aug 22, 2024
@chronolaw chronolaw force-pushed the refactor/clean_helpers_no3 branch from eafe6a0 to 935cdcc Compare September 4, 2024 08:32
@chronolaw chronolaw marked this pull request as ready for review September 4, 2024 08:39
@windmgc windmgc merged commit e4c0e85 into master Sep 5, 2024
27 checks passed
@windmgc windmgc deleted the refactor/clean_helpers_no3 branch September 5, 2024 02:47
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13552-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13552-to-master-to-upstream
git checkout -b cherry-pick-13552-to-master-to-upstream
ancref=$(git merge-base 9bce2d2a846e6f22d83229fbfdcaf4dfa1a40422 935cdcce4b34666b0ea5deeea0ec3a20395a89d6)
git cherry-pick -x $ancref..935cdcce4b34666b0ea5deeea0ec3a20395a89d6

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 5, 2024
andrewgkew pushed a commit to andrewgkew/kong that referenced this pull request Sep 5, 2024
It is one of the serial refactors of helpers.lua

KAG-5242
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants