tests(helpers): separate miscellaneous and shell functions #13542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chronolaw
force-pushed
the
refactor/clean_helpers_no2
branch
from
95d257c to
1228ed8
Compare
chronolaw
changed the title
chronolaw
changed the title
chronolaw
force-pushed
the
refactor/clean_helpers_no2
branch
from
7bda185 to
904d5f5
Compare
Water-Melon
approved these changes
Sep 4, 2024
ADD-SP
approved these changes
Sep 4, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13542-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13542-to-master-to-upstream
git checkout -b cherry-pick-13542-to-master-to-upstream
ancref=$(git merge-base 4abf3ba028b87535c200dc5d00e97b58616116dc 904d5f5fb661d872f24bbd390afe99cb41149bc3)
git cherry-pick -x $ancref..904d5f5fb661d872f24bbd390afe99cb41149bc3 |
github-actions
bot
added
the
incomplete-cherry-pick
andrewgkew
pushed a commit
to andrewgkew/kong
that referenced
this pull request
Sep 5, 2024
It is one of the serial refactors of helpers.lua KAG-5236 The function `kong_exec()` needs an upvalue `conf`, which must be reloaded each time.
kikito
removed
the
incomplete-cherry-pick
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
It is one of the serial refactors of helpers.lua KAG-5236 The function `kong_exec()` needs an upvalue `conf`, which must be reloaded each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It is one of the serial refactors of helpers.lua
KAG-5236
The function
kong_exec()needs a upvalueconf, so it must be reloaded each time.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]