Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins): refine the protocols field in the schema of some plugins #13531

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(plugins): refine the protocols field in the schema of some plugins #13531

wants to merge 3 commits into from
+9 −6

Conversation

liverpool8056
Copy link
Contributor

Summary

change the protocols fields from typedefs.protocols to typedefs.protocols_http in plugin schema for some plugins.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-6186

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 21, 2024
@liverpool8056 liverpool8056 force-pushed the fix-protocols-fields-in-several-plugins branch from a3a3b4b to 43468af Compare August 21, 2024 03:49
@liverpool8056 liverpool8056 added this to the 4.0.0 milestone Aug 22, 2024
@liverpool8056
Copy link
Contributor Author

This should be a bit breaking, so don't merge until 4.x

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 16, 2024
@gszr
Copy link
Member

gszr commented Oct 11, 2024

This should be a bit breaking, so don't merge until 4.x

Let's label this "do not merge", "4.0", and convert it to draft.

@liverpool8056 liverpool8056 added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Oct 12, 2024
@liverpool8056 liverpool8056 marked this pull request as draft October 12, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GGabriele GGabriele Awaiting requested review from GGabriele

At least 2 approving reviews are required to merge this pull request.

Assignees

@liverpool8056 liverpool8056

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/azure-functions plugins/grpc-gateway plugins/grpc-web plugins/proxy-cache plugins/request-transformer plugins/serverless-functions plugins/session pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) schema-change-noteworthy size/S
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liverpool8056 @gszr @team-gateway-bot