[backport -> release/3.8.x] fix(db): pass "read" on read-only database operations #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary @jeremyjpj0916 mentions in discussion thread: https://github.com/Kong/kong/discussions/13513 That Kong may work unexpectedly or require write node for general operation. I did quick search and found couple of missing places where we don't give "read" as a parameter for readonly operations. This may not fix all the issues that we have for how resilient Kong nodes are for write node being offline, but at least it is obvious to fix these at first. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit c29db18)
team-gateway-bot
added
cherry-pick kong-ee
3 tasks
bungle
approved these changes
Aug 20, 2024
nowNick
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/3.8.x, triggered by a label in #13519.Original description
Summary
@jeremyjpj0916 mentions in discussion thread:
#13513
That Kong may work unexpectedly or require write node for general operation.
I did quick search and found couple of missing places where we don't give "read" as a parameter for readonly operations. This may not fix all the issues that we have for how resilient Kong nodes are for write node being offline, but at least it is obvious to fix these at first.
KAG-5196
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md