Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helper): reduce the count of local variables in top level #13526

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 20, 2024

Summary

KAG-5220

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 20, 2024
@chronolaw chronolaw marked this pull request as ready for review August 20, 2024 08:38
@chronolaw chronolaw requested a review from samugi August 20, 2024 09:16
@samugi samugi merged commit c1bd5c6 into master Aug 20, 2024
39 checks passed
@samugi samugi deleted the tests/reduce_vars_in_helpes branch August 20, 2024 16:04
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13526-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13526-to-master-to-upstream
git checkout -b cherry-pick-13526-to-master-to-upstream
ancref=$(git merge-base 6e1fbd6774ce19226aa8113fbbab5b26b400254d b8f39b24e66163c38041bd01e1df7ab2b8f4a137)
git cherry-pick -x $ancref..b8f39b24e66163c38041bd01e1df7ab2b8f4a137

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 20, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants