Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin-gui): bump kong-manager to v3.8.0 #13522

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat(admin-gui): bump kong-manager to v3.8.0 #13522

merged 3 commits into from
Aug 20, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Aug 20, 2024 •
edited
Loading

Summary

This pull request updates KONG_MANAGER to v3.8.0

Checklist

  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md

@sumimakito sumimakito added this to the 3.8.0 milestone Aug 20, 2024
raoxiaoyan
raoxiaoyan requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@raoxiaoyan raoxiaoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the base to release/3.8.x when it is available

@sumimakito sumimakito changed the base branch from master to release/3.8.x August 20, 2024 04:08
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 20, 2024
@Leopoldthecoder Leopoldthecoder force-pushed the feat/kong-manager-3.8.0 branch 2 times, most recently from f61de10 to 464c652 Compare August 20, 2024 06:15
@Leopoldthecoder Leopoldthecoder force-pushed the feat/kong-manager-3.8.0 branch from 464c652 to 72eee0c Compare August 20, 2024 06:19
AndyZhang0707
AndyZhang0707 reviewed Aug 20, 2024
View reviewed changes
.requirements
@@ -21,7 +21,7 @@ LUA_RESTY_WEBSOCKET=966c69c39f03029b9b42ec0f8e55aaed7d6eebc0 # 0.4.0.1
ATC_ROUTER=ffd11db657115769bf94f0c4f915f98300bc26b6 # 1.6.2
SNAPPY=23b3286820105438c5dbb9bc22f1bb85c5812c8a # 1.2.0

KONG_MANAGER=nightly
KONG_MANAGER=v3.8.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version be 3.8.0 for CE?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, kong-manager always uses 4-digit versions:

kong/.requirements

Line 18 in e89feb5

KONG_MANAGER=v3.7.0.0-1

kong/.requirements

Line 15 in 4e006aa

KONG_MANAGER=v3.6.0.0

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review August 20, 2024 11:22
@AndyZhang0707 AndyZhang0707 merged commit f18e8ee into release/3.8.x Aug 20, 2024
26 checks passed
@AndyZhang0707 AndyZhang0707 deleted the feat/kong-manager-3.8.0 branch August 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder left review comments

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

@AndyZhang0707 AndyZhang0707 AndyZhang0707 approved these changes

Assignees

@sumimakito sumimakito

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sumimakito @AndyZhang0707 @Leopoldthecoder @raoxiaoyan