Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificates): can't load certificate related's snis config in dbless mode. #13516

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Aug 19, 2024

Summary

This PP is to fix the problem that was caused by #13357.
The problem was recorded here.
Kong/kubernetes-ingress-controller#6370

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KM-429

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Aug 19, 2024
@raoxiaoyan raoxiaoyan changed the title fix(certificates): can't load certificate related's snis in dbless mode. fix(certificates): can't load certificate related's snis config in dbless mode. Aug 19, 2024
@raoxiaoyan raoxiaoyan added this to the 3.8.0 milestone Aug 19, 2024
@ADD-SP ADD-SP merged commit 8b252c8 into master Aug 19, 2024
28 checks passed
@ADD-SP ADD-SP deleted the fix/certificate_in_dbless branch August 19, 2024 08:23
@raoxiaoyan raoxiaoyan added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 19, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13516-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13516-to-master-to-upstream
git checkout -b cherry-pick-13516-to-master-to-upstream
ancref=$(git merge-base c5566bb21c4459654e1d7d145518b63984329c22 00c5a6e15d027ffe381994711bd7a63180609a12)
git cherry-pick -x $ancref..00c5a6e15d027ffe381994711bd7a63180609a12

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 19, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@raoxiaoyan raoxiaoyan removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants