Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns): disable new dns client by default #13514

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Aug 19, 2024

Summary

For the ongoing 3.8 release, we need to disable the new DNS client by default to avoid breaking the original DNS client's behavior.

Dont merge it until 3.8 RC2, 3.8 RC1 still enables the new DNS client for testing.

Checklist

  • The Pull Request has tests (using original test cases)
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5174

@github-actions github-actions bot added core/templates cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 19, 2024
@chobits chobits marked this pull request as draft August 19, 2024 02:55
@chobits chobits requested a review from chronolaw August 19, 2024 02:55
@chobits chobits added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Aug 19, 2024
@chobits chobits marked this pull request as ready for review August 19, 2024 02:56
@chobits chobits requested a review from ADD-SP August 19, 2024 02:56
@chobits
Copy link
Contributor Author

chobits commented Aug 19, 2024

Dont merge it until 3.8 RC2, 3.8 RC1 still enables the new DNS client for testing.
pr/ready (but hold merge) flag

@AndyZhang0707 AndyZhang0707 added this to the 3.8.0 milestone Aug 20, 2024
@kikito kikito marked this pull request as draft August 20, 2024 08:24
@kikito kikito marked this pull request as ready for review August 20, 2024 08:25
@kikito kikito merged commit 6e1fbd6 into master Aug 20, 2024
53 checks passed
@kikito kikito deleted the fix/disable_new_dns_by_default branch August 20, 2024 08:25
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.8.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.8.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants