feat(tools): add readonly tools.table.EMPTY for common usage
#13492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
core/configuration
cherry-pick kong-ee
chronolaw
force-pushed
the
feat/add_tools_empty_table
branch
from
ed997e3 to
c2f35ff
Compare
chronolaw
changed the title
tools.table.EMPTY for common usagetools.table.EMPTY for common usage
ADD-SP
approved these changes
Aug 13, 2024
outsinre
approved these changes
Aug 13, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13492-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13492-to-master-to-upstream
git checkout -b cherry-pick-13492-to-master-to-upstream
ancref=$(git merge-base 0960f882a944447df02f32390142447d95192d3e 343a3c5254130c24a9cf10985caaf8ba8aaf1ef0)
git cherry-pick -x $ancref..343a3c5254130c24a9cf10985caaf8ba8aaf1ef0 |
github-actions
bot
added
the
incomplete-cherry-pick
|
Should be cherry-picked after the https://github.com/Kong/kong-ee/pull/9950 be merged |
kikito
removed
the
incomplete-cherry-pick
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
Inspired by #13491 This PR did not replace all so-called `EMPTY` tables, only which are obviously read-only. https://konghq.atlassian.net/browse/KAG-5140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #13491.
This PR did not replace all so called
EMPTYtables, only which are obviously readonly.KAG-5140
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]