-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dns): remove unnecessary DNS client initialization #13479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dns init is done in kong/conf_loader/init.lua
:
assert(require("kong.tools.dns")(conf))
From this point on, we can just use the initialized dns client which is already loaded.
I wonder if we can update this https://github.com/Kong/kong-ee/blob/8157e937419695f142fad22e8d76fd98de074876/kong/globalpatches.lua#L536 to something like
|
Seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decK integration tests
dbd94d8
to
bad6b3c
Compare
This reverts commit 20bfcea.
bf0b010
to
1bd9468
Compare
Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the Kong/kong-ee repository. |
Summary
There are muliple duplcated dns initialization which is unnecessary, This PR aims to improve the logic of dns initialization which as less as possible.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5059