[cherry-pick master] tests(plugins): add old version plugin compatibility test (#9077) #13459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the old version plugin against the latest core code. We only focus on whether there is any runtime error in the happy path. Because logic changes from version to version, it is not feasible to test the behavior of the plugin. This test is not guaranteed to capture all interface changes, because it may not be able to cover all the dependent interfaces, and even if the interface is covered, it can't detect interface semantic changes or internal logic changes. These kinds of things still rely on the tests of the interfaces themselves to cover. https://konghq.atlassian.net/browse/FTI-5923
github-actions
bot
added
chore
tzssangglass
approved these changes
Aug 7, 2024
ms2008
approved these changes
Aug 8, 2024
github-actions
bot
added
the
incomplete-cherry-pick
catbro666
removed
the
cherry-pick kong-ee
catbro666
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picking https://github.com/Kong/kong-ee/pull/9077.
Test the old version plugin against the latest core code. We only focus on whether there is any runtime error in the happy path. Because logic changes from version to version, it is not feasible to test the behavior of the plugin.
This test is not guaranteed to capture all interface changes, because it may not be able to cover all the dependent interfaces, and even if the interface is covered, it can't detect interface semantic changes or internal logic changes. These kinds of things still rely on the tests of the interfaces themselves to cover.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-5923