Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering): still encoding with cjson #13441

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 1, 2024

Summary

In #13421 we introduced lua-resty-simdjson, but the behavior of encoding has some differences with cjson, this PR disabled simdjson encoding temporarily.

KAG-5061

Related PR: Kong/lua-resty-simdjson#38

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Aug 1, 2024
kong/clustering/utils.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw force-pushed the fix/disable_simdjson_encoding branch from c0ec70c to de3dec2 Compare August 1, 2024 07:30
@chronolaw chronolaw changed the title fix(clustering): still encoding with cjson fix(clustering): still decoding with cjson Aug 1, 2024
@chronolaw chronolaw added this to the 3.8.0 milestone Aug 1, 2024
@chronolaw chronolaw marked this pull request as draft August 1, 2024 07:44
@chronolaw chronolaw changed the title fix(clustering): still decoding with cjson fix(clustering): still encoding with cjson Aug 1, 2024
@chronolaw chronolaw requested a review from fffonion August 1, 2024 07:49
@chronolaw chronolaw marked this pull request as ready for review August 1, 2024 08:05
@ADD-SP ADD-SP merged commit 6ab6b73 into master Aug 1, 2024
33 checks passed
@ADD-SP ADD-SP deleted the fix/disable_simdjson_encoding branch August 1, 2024 10:01
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants