fix(clustering): fix compat for prometheus ai metrics config fields #13417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
fffonion
changed the title
fffonion
reviewed
Jul 23, 2024
kong/clustering/compat/checkers.lua
Outdated
| @@ -37,6 +37,18 @@ local compatible_checkers = { | |||
| dp_version, log_suffix) | |||
| end | |||
| end | |||
|
|
|||
| if plugin.name == 'prometheus' then | |||
There was a problem hiding this comment.
this file is meant for complex transformations or deprecation message, for this fix we can just add it here https://github.com/Kong/kong/blob/master/kong/clustering/compat/removed_fields.lua#L147
There was a problem hiding this comment.
@fffonion noted. I just made the change
There was a problem hiding this comment.
Thanks! We still need the test you prevsiouly added though, sorry I didn't make it clear 😅
There was a problem hiding this comment.
No worries :)
I have Just added it back
fffonion
reviewed
Jul 23, 2024
fffonion
approved these changes
Jul 23, 2024
oowl
approved these changes
Jul 25, 2024
outsinre
approved these changes
Jul 26, 2024
fffonion
force-pushed
the
feat/fix-prometheus-ai-compat
branch
from
8fd525e to
cae5dfa
Compare
AndyZhang0707
changed the title
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13417-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13417-to-master-to-upstream
git checkout -b cherry-pick-13417-to-master-to-upstream
ancref=$(git merge-base 40c86fa09710d8e59f01f839eb26e45d27257876 cae5dfa222e6c7a242e08eda81a7ed7a1cc2db82)
git cherry-pick -x $ancref..cae5dfa222e6c7a242e08eda81a7ed7a1cc2db82 |
github-actions
bot
added
the
incomplete-cherry-pick
|
here is the cherry pick PR: https://github.com/Kong/kong-ee/pull/9807 |
AndyZhang0707
removed
the
incomplete-cherry-pick
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix compat prometheus ai metrics
https://konghq.atlassian.net/browse/KAG-4934
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]