Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): pr diff #13401

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat(ci): pr diff #13401

merged 1 commit into from
Sep 2, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented Jul 19, 2024

Summary

add an action to enable executing the /prdiff <other-pr-url> command, to get the diff between the current PR's changes and the other PR's (effectively this outputs the diff of the PRs' diffs, using: https://github.com/samugi/gh-compr).

This gives a quick overview of the differences between two PRs and is meant to facilitate the process of reviewing cherry-picks.

Checklist

  • (no) The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • (no) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4999

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Jul 19, 2024
@samugi samugi added skip-changelog and removed chore Not part of the core functionality of kong, but still needed labels Jul 19, 2024
.github/workflows/pr-diff.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Aug 6, 2024
@samugi samugi requested a review from dndx August 6, 2024 12:22
dndx
dndx previously requested changes Aug 12, 2024
.github/workflows/pr-diff.yml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 12, 2024
@samugi samugi requested a review from dndx August 12, 2024 10:48
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Aug 13, 2024
@kikito
Copy link
Member

kikito commented Aug 23, 2024

@outsinre , could you review this? It should help doing CE-> EE cherrypicks

@kikito kikito requested a review from outsinre August 23, 2024 11:36
@outsinre
Copy link
Contributor

@outsinre , could you review this? It should help doing CE-> EE cherrypicks

Let me check.

@samugi samugi dismissed dndx’s stale review September 2, 2024 13:43

change done

add an action to enable executing the `/prdiff <other-pr-url>` command,
to get the diff between the current PR's changes and the other PR's.

This gives a quick overview of the differences between two PRs and is
meant to facilitate the process of reviewing cherry-picks.
@samugi samugi merged commit 4e38b96 into master Sep 2, 2024
25 checks passed
@samugi samugi deleted the feat/ci-pr-diff branch September 2, 2024 14:02
@samugi samugi mentioned this pull request Sep 2, 2024
3 tasks
@samugi samugi added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 6, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants