-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): pr diff #13401
Merged
Merged
feat(ci): pr diff #13401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Jul 19, 2024
samugi
added
skip-changelog
and removed
chore
Not part of the core functionality of kong, but still needed
labels
Jul 19, 2024
dndx
requested changes
Aug 5, 2024
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Aug 6, 2024
dndx
previously requested changes
Aug 12, 2024
dndx
reviewed
Aug 12, 2024
samugi
force-pushed
the
feat/ci-pr-diff
branch
from
August 12, 2024 10:43
339bb2b
to
a194998
Compare
team-eng-enablement
added
author/community
PRs from the open-source community (not Kong Inc)
and removed
author/community
PRs from the open-source community (not Kong Inc)
labels
Aug 13, 2024
@outsinre , could you review this? It should help doing CE-> EE cherrypicks |
kikito
approved these changes
Aug 23, 2024
Let me check. |
outsinre
approved these changes
Aug 26, 2024
add an action to enable executing the `/prdiff <other-pr-url>` command, to get the diff between the current PR's changes and the other PR's. This gives a quick overview of the differences between two PRs and is meant to facilitate the process of reviewing cherry-picks.
samugi
force-pushed
the
feat/ci-pr-diff
branch
from
September 2, 2024 13:44
a194998
to
b228242
Compare
samugi
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Sep 6, 2024
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
size/L
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add an action to enable executing the
/prdiff <other-pr-url>
command, to get the diff between the current PR's changes and the other PR's (effectively this outputs the diff of the PRs' diffs, using: https://github.com/samugi/gh-compr).This gives a quick overview of the differences between two PRs and is meant to facilitate the process of reviewing cherry-picks.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4999