Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dns): simplify the code of new dns utils #13398

Merged
merged 2 commits into from
Jul 25, 2024
Merged

refactor(dns): simplify the code of new dns utils #13398

merged 2 commits into from
Jul 25, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jul 19, 2024 •
edited
Loading

Summary

Merge ready since #12305 was cherry-picked successfully.
Try to improve #12305.
KAG-5001

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jul 19, 2024
@chronolaw chronolaw marked this pull request as ready for review July 19, 2024 07:34
@chronolaw chronolaw force-pushed the refactor/simplify_new_dns_utils branch from d63a7ba to 3d7acd6 Compare July 23, 2024 07:13
chronolaw added 2 commits July 24, 2024 11:42
@chronolaw @chobits
refactor(dns): simplify code of utils
a6439e0 
search_names

local function

parse_resolv_conf
@chronolaw @chobits
fix mistake
1586f84
@chobits chobits force-pushed the refactor/simplify_new_dns_utils branch from 9059e96 to 1586f84 Compare July 24, 2024 03:42
ADD-SP
ADD-SP reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the style _M.func needs to be replaced? 🤔

@chronolaw
Copy link
Contributor Author

Any reason why the style _M.func needs to be replaced? 🤔

One function may be called by another function, local form could be faster than _M.func.

@ADD-SP ADD-SP merged commit 63da83b into master Jul 25, 2024
25 checks passed
@ADD-SP ADD-SP deleted the refactor/simplify_new_dns_utils branch July 25, 2024 05:59
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @team-gateway-bot @chobits @ADD-SP