fix(plugins/http-log): improve concurrency when max_batch_size is set to 1 #13384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm-001
changed the title
github-actions
bot
added
plugins/http-log
cherry-pick kong-ee
3 tasks
outsinre
reviewed
Jul 26, 2024
| @@ -189,12 +190,27 @@ function HttpLogHandler:log(conf) | |||
|
|
|||
| local queue_conf = Queue.get_plugin_params("http-log", conf, make_queue_name(conf)) | |||
| kong.log.debug("Queue name automatically configured based on configuration parameters to: ", queue_conf.name) | |||
| local entry = cjson.encode(kong.log.serialize()) | |||
There was a problem hiding this comment.
Pay attention to @chronolaw PR: #13421
We now use the clustering_utils.json_decode or clustering_utils.json_encode.
| @@ -189,12 +190,27 @@ function HttpLogHandler:log(conf) | |||
|
|
|||
| local queue_conf = Queue.get_plugin_params("http-log", conf, make_queue_name(conf)) | |||
| kong.log.debug("Queue name automatically configured based on configuration parameters to: ", queue_conf.name) | |||
| local entry = cjson.encode(kong.log.serialize()) | |||
|
|
|||
| if queue_conf.max_batch_size == 1 then | |||
There was a problem hiding this comment.
This is a hidden feature. We can update the official doc https://docs.konghq.com/gateway/latest/kong-plugins/queue.
|
Deprecated by #13332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]