Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): cp luarocks-admin to bin #13372

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

curiositycasualty
Copy link
Contributor

@curiositycasualty curiositycasualty commented Jul 12, 2024

Summary

Port of https://github.com/Kong/kong-ee/pull/9671 to ensure that luarocks-admin is present in CE packages/docker images:

$ podman run --user=root --privileged --rm -it kong/kong:master bash -c 'find /usr/local -name luarocks-admin'
/usr/local/lib/luarocks/rocks-5.1/luarocks/3.11.1-1/bin/luarocks-admin

Checklist

  • [na] The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #KAG-911

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 12, 2024
@curiositycasualty curiositycasualty merged commit bec7453 into master Jul 15, 2024
25 of 26 checks passed
@curiositycasualty curiositycasualty deleted the fix/luarocks-admin-cp branch July 15, 2024 23:50
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants