fix(observability): log a single warning when buffer is full until it recovers #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the log buffer was full, a log message was logged for every dropped log entry. This was causing a lot of noise. This commit changes the behavior to only log a single message (per worker) when the log buffer is full. Another message is logged when the buffer resumes accepting new log entries.
github-actions
bot
added
the
cherry-pick kong-ee
hanshuebner
approved these changes
Jul 12, 2024
ADD-SP
reviewed
Jul 15, 2024
ADD-SP
approved these changes
Jul 15, 2024
ADD-SP
changed the title
ADD-SP
changed the title
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the log buffer was full, a log message was logged for every dropped log entry. This was causing a lot of noise.
This commit changes the behavior to only log a single message (per worker) when the log buffer is full. Another message is logged when the buffer resumes accepting new log entries.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4924