chore(build): do not download ngx_brotli with '--//:brotli=false' #13352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
added
skip-changelog
chore
github-actions
bot
added
the
cherry-pick kong-ee
fffonion
approved these changes
Jul 9, 2024
locao
approved these changes
Jul 10, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Had issues with
bazel build //build:kongdue to ngx_brotli. Re-run with--//:brotli=falseand ngx_brotli is still being downloaded, which caused another issue with recursive cloning. This now truly disable ngx_brotli when asked, assuming user has a good reason to.Checklist
- [ ] The Pull Request has tests- [ ] A changelog file has been created underchangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md- [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
Fix #[issue number]