Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): set type of kong.logrotate as config|noreplace avoid overwriting during the upgrade #13348

Merged
merged 6 commits into from
Jul 23, 2024
Merged

fix(build): set type of kong.logrotate as config|noreplace avoid overwriting during the upgrade #13348

merged 6 commits into from
Jul 23, 2024

Conversation

tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Jul 8, 2024 •
edited by jira bot
Loading

…

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix FTI-6079

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 8, 2024
@tzssangglass tzssangglass requested a review from fffonion July 8, 2024 07:58
@tzssangglass
apply comments
ba0ca6d 
Signed-off-by: tzssangglass <[email protected]>
@tzssangglass tzssangglass requested a review from fffonion July 9, 2024 08:00
@tzssangglass
apply comments
111d498 
Signed-off-by: tzssangglass <[email protected]>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 9, 2024
@tzssangglass tzssangglass requested a review from fffonion July 10, 2024 02:37
@tzssangglass
apply comments
b00b76b 
Signed-off-by: tzssangglass <[email protected]>
@ms2008 ms2008 requested a review from Water-Melon July 22, 2024 03:37
windmgc
windmgc approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzssangglass
chore changelog
ad5399f 
Signed-off-by: tzssangglass <[email protected]>
@tzssangglass
Copy link
Member Author

image install -> change `/etc/kong/kong.logrotate` -> remove -> check `/etc/kong/kong.logrotate` has been overwritten image

create /etc/kong/kong.logrotate by user -> install kong would let the user choose whether to overwritten the /etc/kong/kong.logrotate, user can choose keep existent /etc/kong/kong.logrotate

@tzssangglass
chore changlog
0c62d6b 
Signed-off-by: tzssangglass <[email protected]>
@windmgc windmgc merged commit 95fad50 into master Jul 23, 2024
25 checks passed
@windmgc windmgc deleted the FTI-6079 branch July 23, 2024 02:50
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

oowl pushed a commit that referenced this pull request Aug 15, 2024
@tzssangglass @ms2008
fix(build): set type of kong.logrotate as config|noreplace avoid over…
669264e 
…writing during the upgrade (#13348)

 FTI-6079

---------

Signed-off-by: tzssangglass <[email protected]>
(cherry picked from commit 95fad50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsinre outsinre outsinre approved these changes

@windmgc windmgc windmgc approved these changes

@fffonion fffonion Awaiting requested review from fffonion

@Water-Melon Water-Melon Awaiting requested review from Water-Melon

Assignees

@tzssangglass tzssangglass

Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzssangglass @team-gateway-bot @fffonion @windmgc @outsinre