Revert "fix(core): Regex header values in traditional router are now validated" #13328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the `r…" This reverts commit b5f2fd2.
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
chronolaw
approved these changes
Jul 3, 2024
ADD-SP
approved these changes
Jul 4, 2024
|
Add up more context about this reverting. #12365 fixed an issue but it might break some use cases on header matching when using the trad_compat router, and the KIC nightly tests detected that. Fixing this issue is easy, but we need to discuss this potential breaking change internally, so let's revert it firstly to make the KIC tests happy. |
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12365
It fails KIC nightly
Fix https://konghq.atlassian.net/browse/KAG-4788