Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): replace non-ASCII quote in kong.conf.default with normal double quote #13312

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore(docs): replace non-ASCII quote in kong.conf.default with normal double quote #13312

merged 1 commit into from
Jul 1, 2024

Conversation

hanshuebner
Copy link
Contributor

Summary

The non-ASCII double quote will display as garbage if the locale of the terminal is not correctly set, which is something that can happen with Docker in some cases.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@hanshuebner hanshuebner added skip-changelog cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 28, 2024
@hanshuebner hanshuebner force-pushed the fix/ascii-double-quote branch from efc1700 to 4651b15 Compare June 28, 2024 07:23
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 28, 2024
@hanshuebner
chore(docs): replace non-ASCII quote in kong.conf.default with normal…
5e6d157 
… double quote

The non-ASCII double quote will display as garbage if the locale of the
terminal is not correctly set, which is something that can happen with
Docker in some cases.
@hanshuebner hanshuebner force-pushed the fix/ascii-double-quote branch from 4651b15 to 5e6d157 Compare June 28, 2024 07:24
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jun 28, 2024
@bungle
Copy link
Member

bungle commented Jun 28, 2024

This must be someone's editor doing "auto-screwup".

@windmgc windmgc merged commit 63c01e5 into master Jul 1, 2024
10 checks passed
@windmgc windmgc deleted the fix/ascii-double-quote branch July 1, 2024 02:29
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

oowl pushed a commit that referenced this pull request Jul 15, 2024
@hanshuebner @windmgc
chore(docs): replace non-ASCII quote in kong.conf.default with normal…
1b9778c 
… double quote (#13312)

The non-ASCII double quote will display as garbage if the locale of the
terminal is not correctly set, which is something that can happen with
Docker in some cases.

(cherry picked from commit 63c01e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@bungle bungle bungle approved these changes

Assignees

@hanshuebner hanshuebner

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanshuebner @bungle @team-gateway-bot @chronolaw @windmgc