tests(dns): flakiness due to hook conflict #13298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
bungle
approved these changes
Jun 25, 2024
StarlightIbuki
commented
Jun 26, 2024
StarlightIbuki
force-pushed
the
flakiness/hook
branch
from
013d9da to
cee2041
Compare
ADD-SP
reviewed
Jun 26, 2024
|
|
||
| before_each(function() | ||
| client = require("kong.resty.dns.client") | ||
| resolver = require("resty.dns.resolver") | ||
|
|
||
| -- you can replace this `query_func` upvalue to spy on resolver query calls. | ||
| -- you can replace this `resolver.query_func` to spy on resolver query calls. |
There was a problem hiding this comment.
What does this comment mean? I don't understand.
There was a problem hiding this comment.
This means the function is spied(hooked) to inspect the internal behavior of the DNS resolver, and the hook function can be changed. I'm not the one who wrote this originally.
StarlightIbuki
commented
Jul 1, 2024
KAG-4520 change the code order to ensure the resolve isnt released too early and cannot be used
StarlightIbuki
force-pushed
the
flakiness/hook
branch
from
ffab358 to
2b6a280
Compare
ADD-SP
approved these changes
Jul 1, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test suits hook the query function and uses a shared variable to change the hook. This causes conflicts when test A has an aysnc query still running, and B swaps the hook function, so the function will be called more than expected times.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdIssue reference
Fix KAG-4519