-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dao): add ability to select and delete expired entities #13296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Jun 25, 2024
raoxiaoyan
changed the title
fix(dao): query records without ttl condition.
fix(dao): can't be deleted or selected after TTL expires.
Jun 25, 2024
raoxiaoyan
changed the title
fix(dao): can't be deleted or selected after TTL expires.
fix(dao): can't be deleted or selected an entity after TTL expires.
Jun 25, 2024
chobits
reviewed
Jun 27, 2024
raoxiaoyan
force-pushed
the
fix/KM-111
branch
3 times, most recently
from
July 1, 2024 03:22
40d52c9
to
46fae63
Compare
chobits
reviewed
Jul 2, 2024
chobits
reviewed
Jul 2, 2024
ADD-SP
changed the title
fix(dao): can't be deleted or selected an entity after TTL expires.
fix(dao): entity cannot be deleted or selected after TTL expires
Jul 3, 2024
chobits
approved these changes
Jul 3, 2024
ADD-SP
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I missed something, where we used statements like *_skip_ttl
?
ADD-SP
reviewed
Jul 3, 2024
ADD-SP
changed the title
fix(dao): entity cannot be deleted or selected after TTL expires
feat(dao): add ability to select and delete expired entities
Jul 3, 2024
ADD-SP
approved these changes
Jul 3, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13296-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13296-to-master-to-upstream
git checkout -b cherry-pick-13296-to-master-to-upstream
ancref=$(git merge-base 63c01e5a20f46ec550a22370bd4c0bf0446694e5 5da83edf8d43d727e227100bd80ff9f4e8b8dead)
git cherry-pick -x $ancref..5da83edf8d43d727e227100bd80ff9f4e8b8dead |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jul 3, 2024
raoxiaoyan
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jul 4, 2024
oowl
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/db
schema-change-noteworthy
size/L
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before running the TTL cleanup in the background timer. it can't delete or select an entity after the TTL expires.
The context of this PR has been written in KAG-4833.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KM-111, KAG-4833