-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dns): ignore records with non-matching types when parsing answers and disable additional_section #13294
Draft
chobits
wants to merge
6
commits into
master
Choose a base branch
from
fix/cname-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+250
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Jun 24, 2024
chronolaw
reviewed
Jun 25, 2024
chronolaw
reviewed
Jul 2, 2024
chronolaw
approved these changes
Jul 4, 2024
convert it to draft, it may introduce a break change if the dns server can't do recursive resolution |
chobits
force-pushed
the
fix/cname-issue
branch
from
October 12, 2024 03:29
042682c
to
0afbca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the regression caused by #13002, which was reverted in #13276. The kong DNS client incorrectly thinks all the RRs in additional section as results of queried name. This bug is caused by:
This fix now removes records with non-matching types, such as CNAME records from the answers of an A query, and it disables the
ADDITIONAL SECTION
in DNS responses, which was introduced by #8895.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6038, KAG-4787