fix(wasm): disable jit for set_host_properties_handlers() #13227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can trigger a segfault if it is jit-compiled due to the semantics of making an FFI call to a C land function which in turn calls back into a Lua land function.
github-actions
bot
added
core/proxy
cherry-pick kong-ee
flrgh
removed
the
cherry-pick kong-ee
locao
approved these changes
Jun 19, 2024
bungle
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function can trigger a segfault if it is jit-compiled due to the semantics of making an FFI call to a C land function which in turn calls back into a Lua land function.
Fixes a condition introduced in #13222.
No changelog entry required--the bug fixed by this change has not been released anywhere.
KAG-4671