refactor(pdk): simplify private RL pdk #13213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
plugins/response-ratelimiting
cherry-pick kong-ee
ADD-SP
force-pushed
the
add_sp/refactor-rl-pdk
branch
2 times, most recently
from
20bd4ed to
875e135
Compare
ADD-SP
removed
the
cherry-pick kong-ee
|
Will cherry-pick manually. |
StarlightIbuki
approved these changes
Jun 17, 2024
Water-Melon
approved these changes
Jun 17, 2024
ADD-SP
force-pushed
the
add_sp/refactor-rl-pdk
branch
from
875e135 to
51bb578
Compare
github-actions
bot
added
plugins/rate-limiting
cherry-pick kong-ee
ADD-SP
force-pushed
the
add_sp/refactor-rl-pdk
branch
from
51bb578 to
fd74647
Compare
ADD-SP
force-pushed
the
add_sp/refactor-rl-pdk
branch
from
fd74647 to
9920969
Compare
github-actions
bot
added
the
incomplete-cherry-pick
ADD-SP
removed
the
cherry-pick kong-ee
kikito
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The rate-limiting-related headers have no fixed format, different plugins have different formats.
The goal of this private PDK is only to retrieve the RL context in a central place, so it should be enough.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4679