feat(acl): added a config always_use_authenticated_groups to support using authenticated groups even when an authenticated consumer exists.
#13184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
plugins/acl
schema-change-noteworthy
cherry-pick kong-ee
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
5 times, most recently
from
d5f6aaa to
66e51d0
Compare
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
from
66e51d0 to
eef8f21
Compare
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
from
eef8f21 to
3056a31
Compare
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
from
3056a31 to
3b10c9e
Compare
|
Please resolve the conflict. |
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
from
3b10c9e to
ac6d84c
Compare
…t using authenticated groups even when an authenticated consumer exists. Currently, authenticated groups will only be used when there is no consumer or the consumer is anonymous. When there is an authenticated consumer, there is no way to use authenticated groups, only the groups associated with the consumer will be used. This PR adds a config `always_use_authenticated_groups` to support using authenticated groups even when an authenticated consumer exists. If enabled, it will first try to use authenticated groups and will fallback to use the groups associated with the consumer if authenticated groups don't exist, which is consistent with the logic in the anonymous consumer case. https://konghq.atlassian.net/browse/FTI-5945
catbro666
force-pushed
the
fti-5945-authenticated-groups-when-consumer-exists
branch
from
ac6d84c to
441dc7b
Compare
windmgc
approved these changes
Aug 5, 2024
| @@ -16,6 +16,7 @@ return { | |||
| type = "array", | |||
| elements = { type = "string" }, }, }, | |||
| { hide_groups_header = { type = "boolean", required = true, default = false, description = "If enabled (`true`), prevents the `X-Consumer-Groups` header from being sent in the request to the upstream service." }, }, | |||
| { always_use_authenticated_groups = { type = "boolean", required = true, default = false, description = "If enabled (`true`), the authenticated groups will always be used even when an authenticated consumer already exists. If the authenticated groups don't exist, it will fallback to use the groups associated with the consumer. By default the authenticated groups will only be used when there is no consumer or the consumer is anonymous." } }, | |||
There was a problem hiding this comment.
Which part of the code implements the logic of:
it will fallback to use the groups associated with the consumer
and is it covered in the test?
There was a problem hiding this comment.
Yes. The part of the else block. https://github.com/Kong/kong/pull/13184/files#diff-6a2485484a2746e4da00c5a27533d8d45662e48bdf453dd7e596ae5e53e4854dR94
Co-authored-by: Xumin <[email protected]>
StarlightIbuki
approved these changes
Aug 5, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13184-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13184-to-master-to-upstream
git checkout -b cherry-pick-13184-to-master-to-upstream
ancref=$(git merge-base 3a1eeed4a7011259b845cc51b9585e1e1c54de76 6f24d0413fc4b0ce99103ba75595f7c08892464f)
git cherry-pick -x $ancref..6f24d0413fc4b0ce99103ba75595f7c08892464f |
github-actions
bot
added
the
incomplete-cherry-pick
kikito
removed
the
incomplete-cherry-pick
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…t using authenticated groups even when an authenticated consumer exists. (#13184) * feat(acl): added a config `always_use_authenticated_groups` to support using authenticated groups even when an authenticated consumer exists. Currently, authenticated groups will only be used when there is no consumer or the consumer is anonymous. When there is an authenticated consumer, there is no way to use authenticated groups, only the groups associated with the consumer will be used. This PR adds a config `always_use_authenticated_groups` to support using authenticated groups even when an authenticated consumer exists. If enabled, it will first try to use authenticated groups and will fallback to use the groups associated with the consumer if authenticated groups don't exist, which is consistent with the logic in the anonymous consumer case. https://konghq.atlassian.net/browse/FTI-5945 --------- Co-authored-by: Xumin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, authenticated groups will only be used when there is no consumer or the consumer is anonymous. When there is an authenticated consumer, there is no way to use authenticated groups, only the groups associated with the consumer will be used.
This PR adds a config
always_use_authenticated_groupsto support using authenticated groups even when an authenticated consumer exists. If enabled, it will first try to use authenticated groups and will fallback to use the groups associated with the consumer if authenticated groups don't exist, which is consistent with the logic in the anonymous consumer case.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-5945