Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdk): implement private PDK functions to process rate_limiting response headers #13181

Merged
merged 3 commits into from
Jun 17, 2024
Merged

feat(pdk): implement private PDK functions to process rate_limiting response headers #13181

merged 3 commits into from
Jun 17, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Jun 7, 2024 •
edited by jira bot
Loading

REBASE AND MERGE

Summary

Currently, all rate-limiting-like plugins process their own response headers individually, we should unify this process by a private PDK function.

This PR is also for KAG-4679.

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4679

@ADD-SP ADD-SP force-pushed the add_sp/feat-export-rate-limiting-context-to-ctx branch 4 times, most recently from eb483b8 to 2a51106 Compare June 7, 2024 05:52
@ADD-SP ADD-SP changed the title feat(pdk): implement private PDK functions to process rate_limting response headers feat(pdk): implement private PDK functions to process rate_limiting response headers Jun 7, 2024
@ADD-SP ADD-SP force-pushed the add_sp/feat-export-rate-limiting-context-to-ctx branch from f78588b to eff85a9 Compare June 7, 2024 08:58
@ADD-SP ADD-SP marked this pull request as ready for review June 7, 2024 08:59
@ADD-SP ADD-SP requested a review from StarlightIbuki June 11, 2024 03:04
@ADD-SP ADD-SP force-pushed the add_sp/feat-export-rate-limiting-context-to-ctx branch 3 times, most recently from 37ae038 to 28e620b Compare June 11, 2024 05:18
StarlightIbuki
StarlightIbuki reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need unit test coverage for this given it's an addition to the PDK?

@ADD-SP ADD-SP force-pushed the add_sp/feat-export-rate-limiting-context-to-ctx branch from 28e620b to 950fe13 Compare June 11, 2024 09:29
@ADD-SP
Copy link
Contributor Author

ADD-SP commented Jun 11, 2024

Do we need unit test coverage for this given it's an addition to the PDK?

Added

@ADD-SP ADD-SP requested a review from StarlightIbuki June 11, 2024 09:30
StarlightIbuki
StarlightIbuki approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do it with busted. But it's fine

@ADD-SP ADD-SP force-pushed the add_sp/feat-export-rate-limiting-context-to-ctx branch from 950fe13 to 1808c0c Compare June 13, 2024 02:29
@ADD-SP ADD-SP merged commit 9c0aad4 into master Jun 17, 2024
33 checks passed
@ADD-SP ADD-SP deleted the add_sp/feat-export-rate-limiting-context-to-ctx branch June 17, 2024 03:30
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 17, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jun 18, 2024
@Kong Kong deleted a comment from team-gateway-bot Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

Assignees

@ADD-SP ADD-SP

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk plugins/rate-limiting plugins/response-ratelimiting size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADD-SP @Water-Melon @StarlightIbuki @kikito