refactor(pdk/log): optimize log serialize #13177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/logs
cherry-pick kong-ee
bungle
force-pushed
the
chore/pdk-log-serialize-optimizations
branch
5 times, most recently
from
92b5c40 to
8a376bf
Compare
bungle
force-pushed
the
chore/pdk-log-serialize-optimizations
branch
3 times, most recently
from
6695fe1 to
b57128a
Compare
### Summary Just some miscellaneous optimizations to log serializer: - avoid unnecessary table creation and modification - move variable creation closer to usage - do not use tail calls - remove EMPTY_TAB - faster split by dot implementation Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
chore/pdk-log-serialize-optimizations
branch
from
b57128a to
a489f85
Compare
bungle
changed the title
jschmid1
reviewed
Jun 12, 2024
jschmid1
approved these changes
Jun 12, 2024
samugi
approved these changes
Jun 12, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13177-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13177-to-master-to-upstream
git checkout -b cherry-pick-13177-to-master-to-upstream
ancref=$(git merge-base 5c34759a96b82b54a81b8d6ffec6ce60ded15cc6 a489f8550ab25e0f5a66cf32e7eac0dfc55465e6)
git cherry-pick -x $ancref..a489f8550ab25e0f5a66cf32e7eac0dfc55465e6 |
github-actions
bot
added
the
incomplete-cherry-pick
bungle
removed
the
incomplete-cherry-pick
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
Just some miscellaneous optimizations to log serializer: - avoid unnecessary table creation and modification - move variable creation closer to usage - do not use tail calls - remove EMPTY_TAB - faster split by dot implementation Signed-off-by: Aapo Talvensaari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just some miscellaneous optimizations to log serializer:
KAG-4728