refactor(ai-proxy) clean up code and fix gzip response #13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
fffonion
force-pushed
the
ai-proxy-pr
branch
2 times, most recently
from
5db01c5 to
5feeb6c
Compare
fffonion
added a commit
that referenced
this pull request
Jun 4, 2024
fffonion
added a commit
that referenced
this pull request
Jun 7, 2024
fffonion
added a commit
that referenced
this pull request
Jul 17, 2024
fffonion
changed the title
oowl
reviewed
Aug 6, 2024
fffonion
changed the title
…r API To make typo more obvious to be catched
liverpool8056
approved these changes
Aug 7, 2024
| end | ||
|
|
||
| function _M.should_disable_ai_proxy_response_transform() | ||
| return kong.ctx.shared.llm_disable_ai_proxy_response_transform == true |
There was a problem hiding this comment.
Just a tiny suggestion: we can just return kong.ctx.shared.llm_disable_ai_proxy_response_transform since we ensure it is a bool itself by a dedicated function.
There was a problem hiding this comment.
Good point, we can fix in the next round of refactor.
oowl
approved these changes
Aug 7, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13155-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13155-to-master-to-upstream
git checkout -b cherry-pick-13155-to-master-to-upstream
ancref=$(git merge-base c882de932965a21d89100b1f1c1421b627460c4a a69eebff9ee61046c5f5d41d11813f3c9f390757)
git cherry-pick -x $ancref..a69eebff9ee61046c5f5d41d11813f3c9f390757 |
github-actions
bot
added
the
incomplete-cherry-pick
3 tasks
fffonion
added a commit
that referenced
this pull request
Aug 9, 2024
Missing from #13155 Co-authored-by: Xumin <[email protected]>
kikito
removed
the
incomplete-cherry-pick
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Accept-Encodingthat accepts gzipChecklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdIssue reference
AG-39