Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): move changelog files to correct location #13152

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

liverpool8056
Copy link
Contributor

@liverpool8056 liverpool8056 commented Jun 4, 2024

Summary

move changelog files to kong/changelog/unreleased/kong/

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

#13135

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 4, 2024
@liverpool8056 liverpool8056 requested a review from outsinre June 4, 2024 03:29
@outsinre
Copy link
Contributor

outsinre commented Jun 4, 2024

Better link to the original PR.

@@ -25,11 +25,11 @@ jobs:
with:
files_yaml: |
changelogs:
- 'changelog/unreleased/**/*.yml'
- 'changelog/unreleased/*/*.yml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, "**" is a wildcard that matches zero or more directories in a file path, while "*" is a wildcard that matches any single directory or file name in a file path.

So, 'changelog/unreleased/**/.yml' will match all YAML files in any subdirectory under changelog/unreleased, while 'changelog/unreleased/.yml' will only match YAML files directly under changelog/unreleased.

@ms2008 ms2008 merged commit dfbe0c9 into master Jun 4, 2024
5 checks passed
@ms2008 ms2008 deleted the chore-changelog branch June 4, 2024 07:36
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

locao pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants