Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add uninstall test case #13111

Closed
wants to merge 2 commits into from
Closed

tests: add uninstall test case #13111

wants to merge 2 commits into from

Conversation

tzssangglass
Copy link
Member

legacy smoke tests step has been removed, which include uninstall test, this commit move uninstall test to verify manifest test.

FixFTI-5678

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@tzssangglass
tests: add uninstall test case
9ab0de8 
legacy smoke tests step has been removed, which include uninstall test,
this commit move uninstall test to verify manifest test.

Fix[FTI-5678](https://konghq.atlassian.net/browse/FTI-5678)

Signed-off-by: tzssangglass <[email protected]>
@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 30, 2024
@tzssangglass
fix
5f82ab2 
Signed-off-by: tzssangglass <[email protected]>
@tzssangglass tzssangglass marked this pull request as ready for review May 30, 2024 09:42
@tzssangglass tzssangglass requested a review from fffonion May 30, 2024 09:45
@fffonion
Copy link
Contributor

I'm bit hestitated to go with this path as the test seems be lingered. Is it possible to reuse the explain_manifest workflow?
I would also be ok to just drop this test, as the behaviour is not likley going to be changed (i.e. not very necessary to be tested repeatedly).

@tzssangglass
Copy link
Member Author

just drop this test

I feel the same way, I think keeping this PR is enough.

@tzssangglass tzssangglass deleted the FTI-5678 branch January 8, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion Awaiting requested review from fffonion

Assignees

@tzssangglass tzssangglass

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzssangglass @fffonion